docs: fix typos in RELEASE.md#15619
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced May 2, 2026
jdaugherty
reviewed
May 2, 2026
Contributor
jdaugherty
left a comment
jdaugherty
left a comment
There was a problem hiding this comment.
I don't think we should be updating release.md every major version. the document is meant to be examples - its not supposed to track our versions.
Apply three small typo fixes discovered while reviewing RELEASE.md: - `very-reproducible.sh` -> `verify-reproducible.sh` (actual filename of the helper script). - `with be` -> `will be` in the ASF Reporter example. - Close the unbalanced backtick around `<git-tag-of-release>` in the "Appendix: Verification from a Container" section. Per reviewer feedback, RELEASE.md is not kept in sync with the current release version; the existing v7.0.0-M4 / 7.0.x examples are left as illustrative tags. Assisted-by: claude-code:claude-opus-4-7
jamesfredley
changed the title
jamesfredley
force-pushed
the
docs/release-md-update-for-8.0.0-m1
branch
from
7ec72cf to
a1cfbc7
Compare
Contributor
Author
|
Agreed - reverted the version bumps. RELEASE.md should not track our current version; the existing |
jamesfredley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small typo fixes in
RELEASE.md. No version examples are touched - per reviewer feedback, the file should not track the current release version, so the existingv7.0.0-M4/7.0.xexamples are left as illustrative tags.Changes
Manual Verification: Reproducible Jar Filesreferenced a non-existent scriptvery-reproducible.sh. Corrected to the actualverify-reproducible.sh.Update ASF Reporterhad a small typo:with be->will be.Appendix: Verification from a Containerhad an unbalanced backtick in`<git-tag-of-release`. Closed the placeholder.History
This PR previously also bumped every worked example from
v7.0.0-M4/7.0.xtov8.0.0-M1/8.0.xand changed the manual gradle-bootstrap example fromgradle -p gradle-bootstraptocd gradle-bootstrap && gradle. Both have been reverted on @jdaugherty's review:v7.0.0-M4.gradle -p gradle-bootstrapandcd gradle-bootstrap && gradleare functionally identical (-pis the standard--project-dir), so the doc form does not need to change.